lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu, 02 Jul 2015 03:14:11 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Lee Jones <lee.jones@...aro.org>
Cc:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check


Hello,

>>> >> >
>>> >> > Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
>>> >> > Reviewed-by: Vaneet Narang <v.narang@...sung.com>
>>> >> > ---
>>> >> >  drivers/mfd/t7l66xb.c |    4 ++--
>>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>>> >>
>>> >> Applied, with a properly formatted subject line.
>>> >
>>> > Should have probably been more forthcomming with some advice.
>>> >
>>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>>> > the accepted format is.

I did not know this thing.
I will keep that in mind from next time thanks.

>>> ... and a spell-check could be useful as well :). The reviewed-by tag
>>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>>> so I think it should be dropped.

Thanks for your feedback and noticing spell mistake "statndard" :-) and I applied reviewed-by tag in patch,
it is not from LKML, because if we reply any mail, our email client broke the mail thread,
Like my this reply will break down the mail chain from LKML.

>> Fair points.  Patch dropped.
>
>I meant the reviewed-by tag should be dropped :) .
>
>So now... Maninder Singh, could you resent the patch with this minor
>issues fixed?

Yes I am sending patch with these fixes. 

Thanks,
Maninder
.........

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ