linux-kernel - Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 3 Jul 2015 10:02:35 +0800
From:	"Xiao, Jin" <jin.xiao@...el.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	Joerg Roedel <jroedel@...e.de>, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, bp@...e.de, boris.ostrovsky@...cle.com,
	dave.hansen@...ux.intel.com, rientjes@...gle.com,
	imammedo@...hat.com, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	mingo@...nel.org, xinhuix.pan@...el.com
Subject: Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online

Hi tglx,

On 7/2/2015 8:50 PM, Thomas Gleixner wrote:
>
> The whole vector stuff is racy versus cpu hotplug and Jins patch
> merily addresses a small part of it and by doing that it breaks stuff
> as well.
>
> With that patch we move the vector setup after marking the cpu online,
> which is wrong because the vector array on that cpu is not up to date
> until we call __setup_vector_irq(). Proper patch below.
>
> We still have an issue in the cpu_disable() patch, but I haven't yet
> wrapped my head around it completely.
>
> Thanks,
>
> 	tglx
>

Your patch is better. Thanks.

Jin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/