linux-kernel - Re: [PATCH 1/1] sched: apply ifdef CONFIG_SMP to meaningful code only on SMP system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jul 2015 13:27:46 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	byungchul.park@....com
Cc:	mingo@...nel.org, minchan.kim@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] sched: apply ifdef CONFIG_SMP to meaningful code
 only on SMP system

On Sun, Jul 05, 2015 at 06:43:31PM +0900, byungchul.park@....com wrote:
> From: Byungchul Park <byungchul.park@....com>
> 
> account_numa_dequeue and manipulating se->group_node are meaningful only on SMP

Clearly the data element exists for !SMP and you didn't fix that.
Also, try and do this without adding more #ifdef.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/