[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2015 13:55:44 +0300
From: Roger Quadros <rogerq@...com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
<linux-input@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders
On 07/07/15 03:30, Dmitry Torokhov wrote:
> We are using threaded interrupt handler and thus are allowed to sleep.
> Let's switch over to gpiod_get_value_cansleep() so that we do not get
> ugly warnings in case GPIO controller might sleep when accessing GPIO.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
Acked-by: Roger Quadros <rogerq@...com>
cheers,
-roger
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 9093aa9..8965d7c 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -171,7 +171,7 @@ static irqreturn_t pixcir_ts_isr(int irq, void *dev_id)
> /* report it */
> pixcir_ts_report(tsdata, &report);
>
> - if (gpiod_get_value(tsdata->gpio_attb)) {
> + if (gpiod_get_value_cansleep(tsdata->gpio_attb)) {
> if (report.num_touches) {
> /*
> * Last report with no finger up?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists