linux-kernel - Re: [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 23:41:07 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH v6 7/7] zsmalloc: use shrinker to trigger auto-compaction

On (07/07/15 22:44), Minchan Kim wrote:
[..]
> IMO, there is no value to maintain just in case of
> failing register_shrinker in practice.
> 
> Let's remove shrinker_enabled and abort pool creation if shrinker register
> is failed.

But why would we do this? Yes, it's kinda-sorta bad -- we were not
able to register zspool shrinker, so there will be no automatic
compaction... And that's it.

It does not affect zsmalloc/zram functionality by any means. Including
compaction itself -- user still has a way to compact zspool (manually).
And in some scenarios user will never even see automatic compaction in
action (assuming that there is a plenty of RAM available).

Can you explain your decision?

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/