linux-kernel - Re: [PATCH] nouveau/ttm: fix tiled system memory with Maxwell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Jul 2015 17:16:08 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	Ben Skeggs <bskeggs@...hat.com>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nouveau/ttm: fix tiled system memory with Maxwell

Withdrawing this patch which triggered a warning due to a missing
argument to NV_WARN. Sent v2 which addresses this. Sorry for the
noise.

On Wed, Jul 8, 2015 at 4:13 PM, Alexandre Courbot <acourbot@...dia.com> wrote:
> Add Maxwell to the switch statement that sets node->memtype, otherwise
> all tiling information is ignored for buffers in system memory.
>
> While we are at it, make that switch statement explicitly complain the
> next time we meet a non-handled card family.
>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  drm/nouveau/nouveau_ttm.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drm/nouveau/nouveau_ttm.c b/drm/nouveau/nouveau_ttm.c
> index 18f449715788..69bec1058039 100644
> --- a/drm/nouveau/nouveau_ttm.c
> +++ b/drm/nouveau/nouveau_ttm.c
> @@ -175,15 +175,24 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man,
>         node->page_shift = 12;
>
>         switch (drm->device.info.family) {
> +       case NV_DEVICE_INFO_V0_TNT:
> +       case NV_DEVICE_INFO_V0_CELSIUS:
> +       case NV_DEVICE_INFO_V0_KELVIN:
> +       case NV_DEVICE_INFO_V0_RANKINE:
> +       case NV_DEVICE_INFO_V0_CURIE:
> +               break;
>         case NV_DEVICE_INFO_V0_TESLA:
>                 if (drm->device.info.chipset != 0x50)
>                         node->memtype = (nvbo->tile_flags & 0x7f00) >> 8;
>                 break;
>         case NV_DEVICE_INFO_V0_FERMI:
>         case NV_DEVICE_INFO_V0_KEPLER:
> +       case NV_DEVICE_INFO_V0_MAXWELL:
>                 node->memtype = (nvbo->tile_flags & 0xff00) >> 8;
>                 break;
>         default:
> +               NV_WARN(drm, "%s: unhandled family type %x\n",
> +                       drm->device.info.family);
>                 break;
>         }
>
> --
> 2.4.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/