linux-kernel - [PATCH] Cleanup of NXP LPC32XX SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 12 Jul 2015 12:38:40 +0200
From:	Martin Devera <devik@....cz>
To:	unlisted-recipients:; (no To-header on input)
Subject: [PATCH] Cleanup of NXP LPC32XX SPI driver

Debug code is removed.
---
 drivers/spi/spi-lpc32xx.c |   16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/spi/spi-lpc32xx.c b/drivers/spi/spi-lpc32xx.c
index 5c6b1ca..11b2c21 100644
--- a/drivers/spi/spi-lpc32xx.c
+++ b/drivers/spi/spi-lpc32xx.c
@@ -71,15 +71,6 @@ struct spi_lpc32xx_data {
 	unsigned long		rate;	/* master clock rate */
 };
 
-static int spi_lpc32xx_setup(struct spi_device *spi)
-{
-	/* We are expect that SPI-device is not selected */
-	//gpio_direction_output(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));
-//
-	printk("#### Setup spi\n");
-	return 0;
-}
-
 static int spi_lpc32xx_start(struct spi_lpc32xx_data *hw)
 {
 	int sz,mode;
@@ -88,8 +79,6 @@ static int spi_lpc32xx_start(struct spi_lpc32xx_data *hw)
 
 	mode = hw->mode;
 	mode |= (hw->bpw-1)<<9;
-//	printk("in spi_lpc32xx_start sz=%d buf=%p isrd=%d mode=%X io=%p stat=%X\n",
-//			sz,hw->buf,hw->is_rd,mode,hw->syncio,readl(SPI_STAT(hw->syncio)));
 	writel(mode,SPI_CON(hw->syncio));
 	writel(sz,SPI_FRM(hw->syncio));
 	writel(SPI_IER_INTEOT,SPI_IER(hw->syncio));
@@ -145,10 +134,6 @@ static irqreturn_t spi_lpc32xx_isr(int irq, void *dev_id)
 	int sz,i;
 	sz = hw->len;
 	if (sz > 64) sz = 64;
-#if 0
-	printk("in spi_lpc32xx_isr sz=%d buf=%p isrd=%d stat=%X\n",
-			sz,hw->buf,hw->is_rd,readl(SPI_STAT(hw->syncio)));
-#endif
 
 	if (hw->is_rd) {
 		writel(0,SPI_FRM(hw->syncio));
@@ -192,7 +177,6 @@ static int spi_lpc32xx_probe(struct platform_device *pdev)
 	master->bus_num = pdev->id;
 	master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST | SPI_3WIRE;
 	master->bits_per_word_mask =  SPI_BPW_RANGE_MASK(1, 8);
-	master->setup = spi_lpc32xx_setup;
 	master->transfer_one = spi_lpc32xx_transfer_one;
 	master->flags = SPI_MASTER_HALF_DUPLEX;
 	master->dev.of_node = pdev->dev.of_node;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/