linux-kernel - Re: [v5 15/19] KVM: eventfd: add irq bypass consumer management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2015 15:47:23 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Eric Auger <eric.auger@...aro.org>, Feng Wu <feng.wu@...el.com>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	alex.williamson@...hat.com, joro@...tes.org
Subject: Re: [v5 15/19] KVM: eventfd: add irq bypass consumer management

 13/07/2015 15:16, Eric Auger wrote:
>> >  
>> > +	irqfd->consumer.token = (void *)irqfd->eventfd;
>> > +	kvm_arch_irq_consumer_init(&irqfd->consumer);
> what if the architecture does not implement kvm_arch_irq_consumer_init?
> 
> Also you are using here this single function kvm_arch_irq_consumer_init
> to do some irq bypass manager settings + attaching your
> irqfd->arch_update cb which does not really relate to IRQ bypass
> manager. I think I preferred the approach where start/top/add/del were
> exposed separately ([RFC v2 5/6] KVM: introduce kvm_arch functions for
> IRQ bypass).
> 
> Why not adding another kvm_arch_irq_routing_update then, not necessarily
> linked to irq bypass manager.

Yes, I also preferred the dummy kvm_arch_* functions to this approach
with an init function.  You'd have to add dummy init functions anyway
for non-ARM, non-x86 architectures.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/