linux-kernel - RE: [PATCH v3] mfd: add Intel Broxton Whiskey Cove PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2015 17:43:52 +0000
From:	"Yang, Fei" <fei.yang@...el.com>
To:	"Zha, Qipeng" <qipeng.zha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"lee.jones@...aro.org" <lee.jones@...aro.org>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"Zhong, Huiquan" <huiquan.zhong@...el.com>,
	"Chen, Jason CJ" <jason.cj.chen@...el.com>,
	"Zheng, Qi" <qi.zheng@...el.com>,
	"Ortiz, Samuel" <samuel.ortiz@...el.com>
Subject: RE: [PATCH v3] mfd: add Intel Broxton Whiskey Cove PMIC driver

> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 0e5cfeb..5e771a2 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -183,5 +183,6 @@ obj-$(CONFIG_MFD_RT5033)	+= rt5033.o
>  obj-$(CONFIG_MFD_SKY81452)	+= sky81452.o
> 
>  intel-soc-pmic-objs		:= intel_soc_pmic_core.o intel_soc_pmic_crc.o
> +intel-soc-pmic-objs		+= intel_soc_pmic_bxtwc.o

Since you have regmap read/write callbacks implemented in the mfd driver itself now,
this driver would have compile time dependency on the IPC driver. I think you need to
define a CONFIG option for bxtwc depending on CONFIG_INTEL_PMC_IPC.
 

>  obj-$(CONFIG_INTEL_SOC_PMIC)	+= intel-soc-pmic.o
> obj-$(CONFIG_MFD_MT6397)	+= mt6397-core.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/