linux-kernel - Re: [PATCH v4 4/9] drivers: max77693: Move state container to common header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2015 10:06:09 +0900
From:	Krzysztof Kozłowski <k.kozlowski.k@...il.com>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-pm@...r.kernel.org,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
	Chanwoo Choi <cw00.choi@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Subject: Re: [PATCH v4 4/9] drivers: max77693: Move state container to common header

2015-07-13 22:29 GMT+09:00 Jacek Anaszewski <j.anaszewski@...sung.com>:
> Hi Krzysztof,
>
> I have tested leds-max77693 driver with this patch set and it
> works fine.
> Regarding this patch I have one remark: please keep alphabetical
> order and put #include <linux/mfd/max77693-common.h> before
> #include <linux/mfd/max77693-private.h in several places in this
> patch as well as in the patch 5/9.
>
> With those issues addressed:
>
> Acked-by: Jacek Anaszewski <j.anaszewski@...sung.com>

Thanks, I'll reorder the common header and re-spin.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/