linux-kernel - Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2015 19:42:54 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Greg Donald <gdonald@...il.com>
Cc:	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before
 the open parenthesis '('" errors

On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald <gdonald@...il.com>
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    | 97 ++++++++++------------
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>  	pHTInfo->bRegBW40MHz = 1;
>  
>  	// CCK rate support in 40MHz channel
> -	if(pHTInfo->bRegBW40MHz)
> +	if (pHTInfo->bRegBW40MHz)
>  		pHTInfo->bRegSuppCCK = 1;
>  	else
>  		pHTInfo->bRegSuppCCK = true;
> @@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>  
>  	// MIMO Power Save
>  	pHTInfo->SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No Limitation, 2: Reserved(Set to 3 automatically.)
> -	if(pHTInfo->SelfMimoPs == 2)
> +	if (pHTInfo->SelfMimoPs == 2)
>  		pHTInfo->SelfMimoPs = 3;
>  	// 8190 only. Assign rate operation mode to firmware
>  	ieee->bTxDisableRateFallBack = 0;
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>  	static u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};	// For 11n EWC definition, 2007.07.17, by Emily
>  	PHT_CAPABILITY_ELE		pCapELE;
>  
> -	if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> -	{
> +	if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {

Like others have pointed out, this is something different than what you
are saying you are doing, please break this up into different patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/