linux-kernel - Re: [RFC][PATCH 2/2] x86, fpu: enlarge xregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 02:10:23 -0700
From:	Dave Hansen <dave@...1.net>
To:	unlisted-recipients:; (no To-header on input)
CC:	torvalds@...ux-foundation.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org, luto@...capital.net, bp@...en8.de,
	fenghua.yu@...el.com, hpa@...or.com, oleg@...hat.com,
	tglx@...utronix.de, ross.zwisler@...ux.intel.com
Subject: Re: [RFC][PATCH 2/2] x86, fpu: enlarge xregs_state

On 07/16/2015 01:13 AM, Dave Hansen wrote:
> +/*
> + * The largest xsave buffer known today is 2752 bytes on a system
> + * implementing AVX-512.  This includes the 512-byte i387 state
> + * and 64-byte header.  We add a small amount of padding in case
> + * an implementation adds some padding or wastes some space.
> + *
> + * Note, if we overflow this, we will disable XSAVE completely.
> + *
> + * Also, note that the real size we need is enumerated by
> + * cpuid leaves and can not be known at compile time.
> + */
> +#define XSTATE_MAX_SIZE	(2752 + 256)

BTW, this has one big-ish side-effect.  It takes the size of task_struct
from ~3.5k to ~5.4k for me:

slabinfo before:
task_struct          198    198   3456    9    8 : ...
after:
task_struct          166    180   5376    6    8 : ...

I'm sure folks on small systems are going to cringe at eating 2k/thread,
so we've got to revisit this _somehow_.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/