linux-kernel - Re: [PATCH] i2c-parport: Add VCT-jig adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 14:53:24 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	linux-i2c@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c-parport: Add VCT-jig adapter

On Mon, 13 Jul 2015 19:31:12 +0200, Ondrej Zary wrote:
> Add support for VCT-jig parallel port I2C adapter to i2c-parport.
> 
> The adapter schematic can be found here (in the RAR file):
> http://remont-aud.net/shop/22/desc/vct-jig-komplekt-dlja-samostojatelnoj-sborki
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> ---
>  Documentation/i2c/busses/i2c-parport |    1 +
>  drivers/i2c/busses/i2c-parport.h     |    8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/i2c/busses/i2c-parport b/Documentation/i2c/busses/i2c-parport
> index 0e2d17b..c3dbb3b 100644
> --- a/Documentation/i2c/busses/i2c-parport
> +++ b/Documentation/i2c/busses/i2c-parport
> @@ -20,6 +20,7 @@ It currently supports the following devices:
>   * (type=5) Analog Devices evaluation boards: ADM1025, ADM1030, ADM1031
>   * (type=6) Barco LPT->DVI (K5800236) adapter
>   * (type=7) One For All JP1 parallel port adapter
> + * (type=8) VCT-jig
>  
>  These devices use different pinout configurations, so you have to tell
>  the driver what you have, using the type module parameter. There is no
> diff --git a/drivers/i2c/busses/i2c-parport.h b/drivers/i2c/busses/i2c-parport.h
> index 4e12945..84a6616 100644
> --- a/drivers/i2c/busses/i2c-parport.h
> +++ b/drivers/i2c/busses/i2c-parport.h
> @@ -89,6 +89,13 @@ static const struct adapter_parm adapter_parm[] = {
>  		.getsda	= { 0x80, PORT_STAT, 1 },
>  		.init	= { 0x04, PORT_DATA, 1 },
>  	},
> +	/* type 8: VCT-jig */
> +	{
> +		.setsda	= { 0x04, PORT_DATA, 1 },
> +		.setscl	= { 0x01, PORT_DATA, 1 },
> +		.getsda	= { 0x40, PORT_STAT, 0 },
> +		.getscl	= { 0x80, PORT_STAT, 1 },
> +	},
>  };
>  
>  static int type = -1;
> @@ -103,4 +110,5 @@ MODULE_PARM_DESC(type,
>  	" 5 = ADM1025, ADM1030 and ADM1031 evaluation boards\n"
>  	" 6 = Barco LPT->DVI (K5800236) adapter\n"
>  	" 7 = One For All JP1 parallel port adapter\n"
> +	" 8 = VCT-jig\n"
>  );

Looks good.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/