linux-kernel - Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 18 Jul 2015 12:15:13 +0800
From:	zhengxing <zhengxing@...k-chips.com>
To:	Mark Brown <broonie@...nel.org>
CC:	dgreid@...omium.org, dianders@...omium.org, heiko@...ech.de,
	sonnyrao@...omium.org, linux-rockchip@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec


>>> +static int snd_rk_mc_remove(struct platform_device *pdev)
>>> +{
>>> +    struct snd_soc_card *soc_card = platform_get_drvdata(pdev);
>>> +
>>> +    snd_soc_card_set_drvdata(soc_card, NULL);
>>> +    snd_soc_unregister_card(soc_card);
>>> +    platform_set_drvdata(pdev, NULL);
>> No need for any of the _set_drvdata() calls, the core does them and they
>> shouldn't make any difference anyway.
> Done. I will remove *_set_drvdata and *get_drvdata because we don't 
> need them any more.
>
Sorry, I mean just remove platform_set_drvdata(pdev, NULL);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/