linux-kernel - [PATCH 2/2] ACPI / OSL: add comment for the __ref annotation of acpi_os_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Jul 2015 18:50:39 +0200
From:	Mathias Krause <minipli@...glemail.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Mathias Krause <minipli@...glemail.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: [PATCH 2/2] ACPI / OSL: add comment for the __ref annotation of acpi_os_unmap_iomem()

Add a comment clarifying the need for the __ref annotation of
acpi_os_unmap_iomem(). It's safe, however, as acpi_early_init() will set
acpi_gbl_permanent_mmap to 1, disabling the problematic branch.

Signed-off-by: Mathias Krause <minipli@...glemail.com>
Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
---
 drivers/acpi/osl.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 3b8963f21b36..7e85fb84e536 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -442,6 +442,9 @@ static void acpi_os_map_cleanup(struct acpi_ioremap *map)
 	}
 }
 
+/* The __ref annotation is needed as during init we may call out to
+ * __acpi_unmap_table() which is an __init annotated function.
+ */
 void __ref acpi_os_unmap_iomem(void __iomem *virt, acpi_size size)
 {
 	struct acpi_ioremap *map;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/