lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2015 09:23:09 +0800 From: Peter Chen <peter.chen@...escale.com> To: Roger Quadros <rogerq@...com> CC: Li Jun <b47624@...escale.com>, <stern@...land.harvard.edu>, <balbi@...com>, <gregkh@...uxfoundation.org>, <dan.j.williams@...el.com>, <jun.li@...escale.com>, <mathias.nyman@...ux.intel.com>, <tony@...mide.com>, <Joao.Pinto@...opsys.com>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org> Subject: Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support On Fri, Jul 17, 2015 at 01:47:12PM +0300, Roger Quadros wrote: > >> + * DRD mode hardware Inputs > >> + * > >> + * @id: TRUE for B-device, FALSE for A-device. > >> + * @vbus: VBUS voltage in regulation. > >> + * > >> * OTG hardware Inputs > >> * > >> * Common inputs for A and B device > >> @@ -122,7 +127,8 @@ enum otg_fsm_timer { > >> */ > >> struct otg_fsm { > >> /* Input */ > >> - int id; > >> + int id; /* DRD + OTG */ > >> + int vbus; /* DRD only */ > > > > Existing b_sess_vld can be also used for drd only case, no need create > > a new flag. > > b_sess_vld is a bit confusing to people not familiar with OTG. > My suggestion is to use dedicated 'vbus' flag for DRD case > for simplicity. > Since OTG DRD is the subset in OTG FSM (FSM, data structure, APIs, etc), I agree with Jun to reuse existing variables, and we can add some comments for b_sess_vld if needed. > > > >> int adp_change; > >> int power_up; > >> int a_srp_det; > > cheers, > -roger -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists