lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Jul 2015 23:33:23 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Tony Lindgren <tony@...mide.com> Cc: Vignesh R <vigneshr@...com>, Benoit Cousson <bcousson@...libre.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, "Quadros, Roger" <rogerq@...com>, Henrik Rydberg <rydberg@...math.org>, Frodo Lai <frodo.lai@...il.com>, Jingoo Han <jg1.han@...sung.com>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org> Subject: Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt On Sun, Jul 19, 2015 at 11:05:07PM -0700, Tony Lindgren wrote: > * Vignesh R <vigneshr@...com> [150719 21:51]: > > On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: > > > > > > I wonder if driver core should be responsible for clearing wake irq and > > > also for clearing wakeup flag. > > > > > > > AFAICU, wakeup flag is deleted when struct device is deleted, hence, > > device_init_wakeup() call may not be required in .remove(). But, > > dev_pm_clear_wake_irq() can be moved to driver core. > > Currently the lifecycle of struct wakeup_source is not necessarily > the same as the lifecycle struct device. I believe net and usb drivers > at least allocate it dynamically. I am not sure if I follow. I was wondering if we should clear the wakeup IRQ setting on the driver unbinding. It does not mean that we'd be deleting wakeup_source, just that we'll clear wakeup irq setting from it. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists