linux-kernel - Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 08:17:31 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Paolo Pisati <p.pisati@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields


* Paolo Pisati <p.pisati@...il.com> wrote:

> hd0_info and hd1_info are not used anymore, don't reference them in the code
> 
> Signed-off-by: Paolo Pisati <p.pisati@...il.com>
> ---
>  arch/x86/kernel/kexec-bzimage64.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
> index 3666a84..c0ae428 100644
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
>  	/* Default APM info */
>  	memset(&params->apm_bios_info, 0, sizeof(params->apm_bios_info));
>  
> -	/* Default drive info */
> -	memset(&params->hd0_info, 0, sizeof(params->hd0_info));
> -	memset(&params->hd1_info, 0, sizeof(params->hd1_info));
> -
>  	if (image->type == KEXEC_TYPE_CRASH) {
>  		ret = crash_setup_memmap_entries(image, params);
>  		if (ret)

But they are not unused: we pass them to secondary kernel images, via kcrash for 
example.

So it makes sense to zero out these parameters.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/