linux-kernel - Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 23:00:38 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	Spencer Baugh <sbaugh@...ern.com>,
	Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...gic.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Joern Engel <joern@...estorage.com>,
	Spencer Baugh <Spencer.baugh@...estorage.com>,
	Dilip Kumar Uppugandla <dilip@...estorage.com>
Subject: Re: [PATCH] qla2xxx: Return the fabric command state for non-task
 management requests



On 7/21/15, 3:07 PM, "Spencer Baugh" <sbaugh@...ern.com> wrote:

>From: Dilip Kumar Uppugandla <dilip@...estorage.com>
>
>Invoking get_cmd_state for qla2xxx always returns 0. Instead change it
>to return the actual fabric state from qla_tgt_cmd. This will help with
>debugging.
>
>Signed-off-by: Dilip Kumar Uppugandla <dilip@...estorage.com>
>Signed-off-by: Spencer Baugh <sbaugh@...ern.com>
>---
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>index d9a8c60..e859586 100644
>--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>@@ -420,6 +420,12 @@ static void
>tcm_qla2xxx_set_default_node_attrs(struct se_node_acl *nacl)
> 
> static int tcm_qla2xxx_get_cmd_state(struct se_cmd *se_cmd)
> {
>+	if (!(se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) {
>+		struct qla_tgt_cmd *cmd = container_of(se_cmd,
>+				struct qla_tgt_cmd, se_cmd);
>+		return cmd->state;
>+	}
>+
> 	return 0;
> }
> 
>-- 
>2.4.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Looks Good. 

Acked-by: Himanshu Madhani <himanshu.madhani@...gic.com>

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/