linux-kernel - Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2015 08:17:11 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	linux-samsung-soc@...r.kernel.org,
	Heiko Stuebner <heiko@...ech.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Doug Anderson <dianders@...omium.org>,
	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

On Thu, 25 Jun 2015, Lee Jones wrote:

> On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> 
> > The ChromeOS EC SPI transport driver has a dependency on OF because it
> > uses some OF helpers from the <linux/of.h> header. But there isn't a
> > need for an explicit dependency since the header has stub functions if
> > CONFIG_OF is not defined.
> > 
> > Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> > a dependency on OF so in practice can't be selected without CONFIG_OF.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> > 
> > ---
> > 
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied for v4.3, thanks.

Now applied for v4.2, thanks.

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 653815950aa2..3f68dd251ce8 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
> >  
> >  config MFD_CROS_EC_SPI
> >  	tristate "ChromeOS Embedded Controller (SPI)"
> > -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> > +	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
> >  
> >  	---help---
> >  	  If you say Y here, you get support for talking to the ChromeOS EC
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/