linux-kernel - Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jul 2015 10:30:14 +0200
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	Kukjin Kim <kgene@...nel.org>, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] PM / devfreq: event: Remove incorrect property in
 exynos-ppmu DT binding

Hello Chanwoo,

On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
> Hi Javier,
> 
> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>> The exynos-ppmu driver is only a clock consumer and not a clock
>> provider but its Device Tree binding listed #clock-cells as an
>> optional property.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>> 
>> ---
>> 
>> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1
>> - 1 file changed, 1 deletion(-)
>> 
>> diff --git
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> index b54bf3a2ff57..aed486692880 100644 ---
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> +++
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> @@ -17,7 +17,6 @@ Required properties: Optional properties: -
>> clock-names : the name of clock used by the PPMU, "ppmu" - clocks :
>> phandles for clock specified in "clock-names" property --
>> #clock-cells: should be 1.
>> 
>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>> 
>> 
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
> 
> + Devfreq maintainer (Myungjoo Ham)

Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
MAINTAINERS file.

> I think that this patch will be more appropriate on devfreq git tree 
> than linux-samsung git tree.
>

Agreed.

> Thanks, Chanwoo Choi --

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/