lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jul 2015 09:55:47 +0800 From: Pan Xinhui <xinhuix.pan@...el.com> To: "Elliott, Robert (Server Storage)" <Elliott@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: Thomas Gleixner <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, "bp@...e.de" <bp@...e.de>, "Kani, Toshimitsu" <toshi.kani@...com>, "jgross@...e.com" <jgross@...e.com>, "mcgrof@...e.com" <mcgrof@...e.com>, "mnipxh@....com" <mnipxh@....com>, "yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>, Borislav Petkov <bp@...en8.de> Subject: Re: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype hi, Elliot thanks for your reply. On 2015年07月22日 22:38, Elliott, Robert (Server Storage) wrote: > > > --- > Robert Elliott, HP Server Storage > >> -----Original Message----- >> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel- >> owner@...r.kernel.org] On Behalf Of Pan Xinhui >> Sent: Wednesday, July 22, 2015 8:27 AM > ... >> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c >> index 188e3e0..8fa1f07 100644 >> --- a/arch/x86/mm/pat.c >> +++ b/arch/x86/mm/pat.c >> @@ -521,10 +521,7 @@ int reserve_memtype(u64 start, u64 end, enum >> page_cache_mode req_type, >> >> is_range_ram = pat_pagerange_is_ram(start, end); >> if (is_range_ram == 1) { >> - >> - err = reserve_ram_pages_type(start, end, req_type, new_type); >> - >> - return err; >> + return reserve_ram_pages_type(start, end, req_type, new_type); >> } else if (is_range_ram < 0) { >> return -EINVAL; >> } > > With each branch now just one line, the {} can be removed. > thanks for the nice tips. sorry for my mistakes. thanks xinhui > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists