linux-kernel - Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Jul 2015 16:42:44 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Philip Müller <philm@...jaro.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Guenter Roeck <linux@...ck-us.net>, manjaro-dev@...jaro.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andre Przywara <andre.przywara@....com>,
	Borislav Petkov <bp@...e.de>
Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs
 code to generic infrastructure' on AMD i686

On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
> I can confirm your patch working. However, it might be good to use yours
> and Thomas' in combination to solve this properly.

Please do not top-post.

We could use Thomas' too although from looking at it,
detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
for each CPU. By the time we hit cache_shared_cpu_map_remove() in
free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
allocated. We kfree them in the next step only.

But I like the moving of the check from the CPU hotplug callback to
free_cache_attributes().

So I'll merge the two patches and write up a proper commit message,
unless someone objects.

I'll add your Tested-by too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/