linux-kernel - Re: [PATCH] cpu/cacheinfo: Fix teardown path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2015 09:56:17 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Borislav Petkov <bp@...e.de>, Thomas Gleixner <tglx@...utronix.de>
CC:	Sudeep Holla <sudeep.holla@....com>,
	Philip Müller <philm@...jaro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"manjaro-dev@...jaro.org" <manjaro-dev@...jaro.org>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andre Przywara <Andre.Przywara@....com>
Subject: Re: [PATCH] cpu/cacheinfo: Fix teardown path



On 27/07/15 08:58, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> Date: Mon, 27 Jul 2015 08:36:27 +0200
> Subject: [PATCH] cpu/cacheinfo: Fix teardown path
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Philip Müller reported a hang when booting 32-bit 4.1 kernel on an AMD
> box. A fragment of the splat was enough to pinpoint the issue:
>
>    task: f58e0000 ti: f58e8000 task.ti: f58e800
>    EIP: 0060:[<c135a903>] EFLAGS: 00010206 CPU: 0
>    EIP is at free_cache_attributes+0x83/0xd0
>    EAX: 00000001 EBX: f589d46c ECX: 00000090 EDX: 360c2000
>    ESI: 00000000 EDI: c1724a80 EBP: f58e9ec0 ESP: f58e9ea0
>     DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
>    CR0: 8005003b CR2: 000000ac CR3: 01731000 CR4: 000006d0
>
> cache_shared_cpu_map_setup() did check sibling CPUs cacheinfo descriptor
> while the respective teardown path cache_shared_cpu_map_remove() didn't.
> Fix that.
>
>  From tglx's version: to be on the safe side, move the cacheinfo
> descriptor check to free_cache_attributes(), thus cleaning up the
> hotplug path a little and making this even more robust.
>
> Reported-by: Philip Müller <philm@...jaro.org>
> Cc: <stable@...r.kernel.org> # 4.1
> Cc: Andre Przywara <andre.przywara@....com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: manjaro-dev@...jaro.org
> Cc: Philip Müller <philm@...jaro.org>
> Cc: Sudeep Holla <sudeep.holla@....com>

Looks good to me. If not too late
Acked-by: Sudeep Holla <sudeep.holla@....com>

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/