[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 27 Jul 2015 10:20:12 +0800
From: yalin wang <yalin.wang2010@...il.com>
To: Minfei Huang <mnfhuang@...il.com>
Cc: rostedt@...dmis.org, mingo@...hat.com,
linux-kernel@...r.kernel.org, mhuang@...hat.com
Subject: Re: [PATCH 2/2] ftrace: Make if condition correctly due to the operator order
> On Jul 26, 2015, at 23:55, Minfei Huang <mnfhuang@...il.com> wrote:
>
> The if condition will be always true, since the operator & has the high
> priority than operator ||.
>
> Use () to quote them to make the if condition correctly.
>
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index c04dff9..d9acc6a 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -254,7 +254,7 @@ static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops)
> * If this is a dynamic ops or we force list func,
> * then it needs to call the list anyway.
> */
> - if (ops->flags & FTRACE_OPS_FL_DYNAMIC || FTRACE_FORCE_LIST_FUNC)
> + if (ops->flags & (FTRACE_OPS_FL_DYNAMIC || FTRACE_FORCE_LIST_FUNC))
> return ftrace_ops_list_func;
>
> return ftrace_ops_get_func(ops);
> —
i think the original code is correct, while your change is wrong from logic.
am i missing something ?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists