linux-kernel - Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2015 15:29:37 +0200
From:	Niklas Cassel <niklas.cassel@...s.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Niklas Cassel <niklass@...s.com>
CC:	Guenter Roeck <linux@...ck-us.net>, Jiri Slaby <jslaby@...e.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	Jesper Nilsson <jespern@...s.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API

On 07/27/2015 03:16 PM, Linus Walleij wrote:
> On Fri, Jul 24, 2015 at 12:23 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote:
>>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>> makes the flags argument to devm_gpiod_get_optional mandatory but does not
>>> update all users. This results in the following build error.
>>>
>>> drivers/tty/serial/etraxfs-uart.c:933:16: error:
>>>       too few arguments to function ‘devm_gpiod_get_optional’
>>>
>>> Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>
>> This patch isn't in Linus's tree, so whatever tree this commit is in,
>> needs to also take this fix.
> 
> OK I'll take it. It's a bit messy with this breakage but it is for
> a good cause.
> 
> Niklas: send me your patch when finished.

I've already sent them to the linux-serial and linux-kernel mailing lists.

I'm sorry that I didn't think of CC:ing you Linus.
It might be better if you take them, since you got
the devm_gpiod_get_optional patches in your tree.


http://marc.info/?l=linux-serial&m=143778406314867

http://marc.info/?l=linux-serial&m=143778407714871

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/