linux-kernel - Re: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for ls1021a

Open Source and information security mailing list archives

Date:	Tue, 28 Jul 2015 09:49:46 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Alison Wang <b18965@...escale.com>
Cc:	shawn.guo@...aro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Wang Dongsheng <dongsheng.wang@...escale.com>,
	Alison Wang <alison.wang@...escale.com>
Subject: Re: [PATCH v2] ARM: dts: ls1021a: add wakeup device ftm0 node for
 ls1021a

On Wed, Jul 15, 2015 at 03:40:11PM +0800, Alison Wang wrote:
> Add ftm0 node, cause of ftm0 can be set as a alarm before system
> going to deep sleep.
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang@...escale.com>
> Signed-off-by: Alison Wang <alison.wang@...escale.com>
> ---
> Changes since v1:
> - Add my SoB.
> - Use "ARM:" as subject prefix.
> 
>  arch/arm/boot/dts/ls1021a-qds.dts | 4 ++++
>  arch/arm/boot/dts/ls1021a.dtsi    | 8 ++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 9c5e16b..f14731b 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -75,6 +75,10 @@
>  	};
>  };
>  
> +&ftm0 {
> +	status = "okay";
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c70bb27..7e9e122 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -332,6 +332,14 @@
>  			status = "disabled";
>  		};
>  
> +		ftm0: ftm0@...0000 {

Is the '0' in the node name is an instance number?  If so, please drop
it from node name.
		ftm0: ftm@...0000 {

> +			compatible = "fsl,ftm-alarm";

Undocumented compatible string.

Shawn

> +			reg = <0x0 0x29d0000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> +			big-endian;
> +			status = "disabled";
> +		};
> +
>  		wdog0: watchdog@...0000 {
>  			compatible = "fsl,imx21-wdt";
>  			reg = <0x0 0x2ad0000 0x0 0x10000>;
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives