linux-kernel - Re: [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 14:02:59 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Brian Norris <computersforpeace@...il.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregory.0xf0@...il.com
Subject: Re: [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with
 CONFIG_PM_SLEEP=n

On Mon, Jul 27, 2015 at 12:54:07PM -0700, Florian Fainelli wrote:
> On 14/07/15 15:06, Brian Norris wrote:
> > On Tue, Jul 14, 2015 at 01:03:33PM -0700, Florian Fainelli wrote:
> >> When CONFIG_PM_SLEEP is disabled, brcm_ahci_{suspend,resume} are not
> >> used, which causes such a build warning to occur:
> >>
> >>   CC      drivers/ata/ahci_brcmstb.o
> >> drivers/ata/ahci_brcmstb.c:212:12: warning: 'brcm_ahci_suspend' defined
> >> but not used [-Wunused-function]
> >>  static int brcm_ahci_suspend(struct device *dev)
> >>             ^
> >> drivers/ata/ahci_brcmstb.c:224:12: warning: 'brcm_ahci_resume' defined
> >> but not used [-Wunused-function]
> >>  static int brcm_ahci_resume(struct device *dev)
> >>             ^
> >>   LD      drivers/ata/built-in.o
> >>
> >> Fixes: 766a2d979632 ("ata: add Broadcom AHCI SATA3 driver for STB chips")
> >> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> >> ---
> >> Tejun, this is a new driver that got merged during 4.2, could you queue
> >> this up for an upcoming 4.2-rcX pull request?
> > 
> > Acked-by: Brian Norris <computersforpeace@...il.com>
> > 
> 
> Tejun, I am not seeing this change queued in your for-4.2-fixes branch
> did you need me to do anything?

Oops, I missed it, sorry.  Applied to libata/for-4.2-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/