lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Jul 2015 01:47:52 +0100 From: Andrew Cooper <andrew.cooper3@...rix.com> To: Andy Lutomirski <luto@...capital.net>, Boris Ostrovsky <boris.ostrovsky@...cle.com> Cc: "security@...nel.org" <security@...nel.org>, Peter Zijlstra <peterz@...radead.org>, X86 ML <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Steven Rostedt <rostedt@...dmis.org>, xen-devel <xen-devel@...ts.xen.org>, Borislav Petkov <bp@...en8.de>, Jan Beulich <jbeulich@...e.com>, Sasha Levin <sasha.levin@...cle.com> Subject: Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option On 29/07/2015 01:21, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky > <boris.ostrovsky@...cle.com> wrote: >> On 07/28/2015 01:07 PM, Andy Lutomirski wrote: >>> On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper >>> <andrew.cooper3@...rix.com> wrote: >>>> I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before >>>> xen_free_ldt() is attempting to nab back the pages which Xen still has >>>> mapped as an LDT. >>>> >>> I just instrumented it with yet more LSL instructions. I'm pretty >>> sure that set_ldt really is clearing at least LDT entry zero. >>> Nonetheless the free_ldt call still oopses. >>> >> Yes, I added some instrumentation to the hypervisor and we definitely set >> LDT to NULL before failing. >> >> -boris > Looking at map_ldt_shadow_page: what keeps shadow_ldt_mapcnt from > getting incremented once on each CPU at the same time if both CPUs > fault in the same shadow LDT page at the same time? Nothing, but that is fine. If a page is in use in two vcpus LDTs, it is expected to have a type refcount of 2. > Similarly, what > keeps both CPUs from calling get_page_type at the same time and > therefore losing track of the page type reference count? a cmpxchg() loop in the depths of __get_page_type(). > > I don't see why vmalloc or vm_unmap_aliases would have anything to do > with this, though. Nor me. I have compiled your branch and will see about reproducing the issue myself tomorrow. ~Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists