linux-kernel - Re: [PATCH 1/4] opp: add dev_pm_opp_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jul 2015 15:54:35 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Rafael Wysocki <rjw@...ysocki.net>, linaro-kernel@...ts.linaro.org,
	linux-pm@...r.kernel.org, b.zolnierkie@...sung.com, nm@...com,
	sboyd@...eaurora.org, Tomasz Figa <tomasz.figa@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Thomas Abraham <thomas.ab@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper

On 28-07-15, 16:27, Pavel Machek wrote:
> Typo.
> 
> And this is not exactly most helpful comment. opp is turbo... returns
> if opp was turbo. Explanation what "turbo" means in this context would
> be nice. I'm pretty sure it is not about air compression :-).

Does this make it any better:

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index e039cf024a6c..da8ec7f824d5 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -281,9 +281,13 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
 EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq);
 
 /**
- * dev_pm_opp_is_turbo() - Returns true if opp was trubo OPP
+ * dev_pm_opp_is_turbo() - Returns if opp is turbo OPP or not
  * @opp: opp for which turbo mode is being verified
  *
+ * Turbo OPPs are not for normal use, and can be enabled (under certain
+ * conditions) for short duration of times to finish high throughput work
+ * quickly. Running on them for longer times may overheat the chip.
+ *
  * Return: true if opp is turbo opp, else false.
  *
  * Locking: This function must be called under rcu_read_lock(). opp is a rcu


-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/