linux-kernel - Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jul 2015 10:16:19 +0300
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Chunyan Zhang <zhang.lyra@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	peter.lachner@...el.com, norbert.schulz@...el.com,
	keven.boell@...el.com, yann.fouassier@...el.com,
	laurent.fert@...el.com,
	"linux-api\@vger.kernel.org" <linux-api@...r.kernel.org>,
	Chunyan Zhang <zhang.chunyan@...aro.org>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

Chunyan Zhang <zhang.lyra@...il.com> writes:

> The code has already been submitted like I said in the earlier emails,
> you may refer [1].
>
> Thanks,
> Chunyan
>
> [1] https://lkml.org/lkml/2015/2/4/729

This code does the following (pasting from that patch):

in stm_probe():

drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);

... something irrelevant ...

ret = clk_prepare_enable(drvdata->clk);

... something irrelevant ...

clk_disable_unprepare(drvdata->clk);

... something irrelevant ...

drvdata->clk = adev->pclk;

How is this supposed to even work?

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/