linux-kernel - Re: [PATCH] target: allow underflow/overflow for PR OUT etc. commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Jul 2015 23:44:23 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Spencer Baugh <sbaugh@...ern.com>
Cc:	"open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
	"open list:TARGET SUBSYSTEM" <target-devel@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Joern Engel <joern@...estorage.com>,
	Spencer Baugh <Spencer.baugh@...estorage.com>,
	Roland Dreier <roland@...estorage.com>
Subject: Re: [PATCH] target: allow underflow/overflow for PR OUT etc.
 commands

On Wed, 2015-07-22 at 15:08 -0700, Spencer Baugh wrote:
> From: Roland Dreier <roland@...estorage.com>
> 
> It's not necessarily a fatal error if a command with a data-out phase
> has a data length that differs from the transport data length (e.g.
> PERSISTENT RESERVE OUT might have a parameter list length in the CDB
> that's smaller than the FC_DL field), so allow these commands.  The
> Windows compliance test sends them.
> 
> Signed-off-by: Roland Dreier <roland@...estorage.com>
> Signed-off-by: Spencer Baugh <sbaugh@...ern.com>
> ---
>  drivers/target/target_core_transport.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index ac002a7..f6626bb 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1087,9 +1087,9 @@ target_cmd_size_check(struct se_cmd *cmd, unsigned int size)
>  			" 0x%02x\n", cmd->se_tfo->get_fabric_name(),
>  				cmd->data_length, size, cmd->t_task_cdb[0]);
>  
> -		if (cmd->data_direction == DMA_TO_DEVICE) {
> -			pr_err("Rejecting underflow/overflow"
> -					" WRITE data\n");
> +		if (cmd->data_direction == DMA_TO_DEVICE &&
> +		    cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {
> +			pr_err("Rejecting underflow/overflow WRITE data\n");
>  			return TCM_INVALID_CDB_FIELD;
>  		}
>  		/*

Applied to target-pending/for-next.

Thanks Roland & Co.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/