linux-kernel - Re: [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2015 10:17:13 +0200
From:	Robert Baldyga <r.baldyga@...sung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
	jslaby@...e.cz, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes

On 07/31/2015 10:04 AM, Krzysztof Kozlowski wrote:
> 2015-07-30 18:14 GMT+09:00 Robert Baldyga <r.baldyga@...sung.com>:
>> Hello,
>>
>> This patch set fixes bug causing serial hang in DMA mode for FIFO sizes
>> smaller than cache alignment. The first patch fixes DMA mode entering
>> condition to avoid starting with buffer smaller than cache line size.
>> Second patch fixes the serial hang bug, which was caused by unproper
>> buffer aligning algorithm which assumed that there is always enough
>> free space in FIFO for excessive bytes of buffer that is being alligned.
>>
>> Best regards,
>> Robert Baldyga
>>
>> Marek Szyprowski (1):
>>   serial: samsung: calculate min_dma_size
>>
>> Robert Baldyga (1):
>>   serial: samsung: fix DMA for FIFO smaller than cache line size
>>
>>  drivers/tty/serial/samsung.c | 47 +++++++++++++++++++++++++++++---------------
>>  drivers/tty/serial/samsung.h |  1 +
>>  2 files changed, 32 insertions(+), 16 deletions(-)
> 
> Does this apply for stable backporting? Or at least fixes tag
> indicating a bug? I could not figure this out from description of
> first patch. For second patch it seems it applies.

These patches are two steps of fixing the bug, so they both apply for
stable backporting.

> 
> Anyway I would appreciate a reported-by credits.

Sure ;)

Thanks,
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/