linux-kernel - [PATCH] staging: lustre: drop redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2015 16:32:43 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	akpm@...ux-foundation.org
Cc:	linaro-kernel@...ts.linaro.org,
	Viresh Kumar <viresh.kumar@...aro.org>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	devel@...verdev.osuosl.org (open list:STAGING SUBSYSTEM),
	Dmitry Eremin <dmiter4ever@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	HPDD-discuss@...ts.01.org (moderated list:STAGING - LUSTRE PARALLEL
	FILESYSTEM), Joe Perches <joe@...ches.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	linux-kernel@...r.kernel.org (open list),
	Oleg Drokin <oleg.drokin@...el.com>,
	Supriya Karanth <iskaranth@...il.com>
Subject: [PATCH] staging: lustre: drop redundant check

There is no need to verify that its an error, as we are anyway going to
match the error value to -ENOENT.  Drop the redundant check.

Reported-by: "Kirill A. Shutemov" <kirill@...temov.name>
Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
---
 drivers/staging/lustre/lustre/obdclass/lu_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
index 6cd3af8c6237..8e472327c880 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
@@ -674,7 +674,7 @@ static struct lu_object *lu_object_find_try(const struct lu_env *env,
 	cfs_hash_bd_lock(hs, &bd, 1);
 
 	shadow = htable_lookup(s, &bd, f, waiter, &version);
-	if (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) {
+	if (likely(PTR_ERR(shadow) == -ENOENT)) {
 		struct lu_site_bkt_data *bkt;
 
 		bkt = cfs_hash_bd_extra_get(hs, &bd);
-- 
2.4.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/