linux-kernel - checkpatch warns about Fixes: lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2015 14:24:46 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org
Subject: checkpatch warns about Fixes: lines

Andy, Joe,

Checkpatch (as shipped in today's linux-next) warns about "Fixes:"
lines:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")'
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

total: 1 errors, 1 warnings, 8 lines checked

Your patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Both warnings seem false positives. "Fixes:" lines should be one line,
shouldn't they, and I think I did use the correct commit description
style here.

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/