linux-kernel - ARM: SAMSUNG: mach-s3c24xx: setup-camif: dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2015 21:01:29 +0200
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	kgene@...nel.org, k.kozlowski@...sung.com,
	Paul Bolle <pebolle@...cali.nl>, linux-kernel@...r.kernel.org
Subject: ARM: SAMSUNG: mach-s3c24xx: setup-camif: dead code

Hi Kukjin,

your commit a1bd8d8bb890 ("ARM: SAMSUNG: make local setup-camif in
mach-s3c24xx") is in today's linux-next tree (i.e., next-20150731) and
it adds the following lines of code with
arch/arm/mach-s3c24xx/setup-camif.c:

+#ifdef CONFIG_ARCH_S3C24XX
+       *gpio_start = S3C2410_GPJ(0);
+       *gpio_reset = S3C2410_GPJ(12);
+#else
+       /* s3c64xx */
+       *gpio_start = S3C64XX_GPF(0);
+       *gpio_reset = S3C64XX_GPF(3);
+#endif

The problem is that the #else block cannot be compiled at the current
state, since the #ifdef block will _always_ be selected by the C
preprocessor due to some build constraints from Makefiles, see
arch/arm/Makefile line 196:

machine-$(CONFIG_ARCH_S3C24XX)

Hence CONFIG_ARCH_S3C24XX will always be set when compiling
arch/arm/mach-s3c24xx/setup-camif.c.

I detected this issue with undertaker-checkpatch from [1].

Kind regards,
 Valentin

[1] https://undertaker.cs.fau.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/