linux-kernel - Re: [PATCH] iio: declare struct to fix warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 02 Aug 2015 11:47:27 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Pengyu Ma <pengyu.ma@...driver.com>, jic23@...nel.org,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: declare struct to fix warning

On 07/30/2015 11:18 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
> 
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
> 
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>            struct iio_dev *indio_dev);
> 
> 1st warning: 'struct iio_trigger' was used before declaration;
> 2nd warning: 'struct iio_dev' was used without including head file.
> 
> Signed-off-by: Pengyu Ma <pengyu.ma@...driver.com>
> ---
>  include/linux/iio/trigger.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 68f46cd..cbe4286 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -9,6 +9,7 @@
>  #include <linux/irq.h>
>  #include <linux/module.h>
>  #include <linux/atomic.h>
> +#include <linux/iio/iio.h>
>  

Instead of including iio.h just add a forward declaration for struct
iio_dev. We dont need to dereference the struct so that will be fine.

>  #ifndef _IIO_TRIGGER_H_
>  #define _IIO_TRIGGER_H_
> @@ -18,6 +19,8 @@ struct iio_subirq {
>  	bool enabled;
>  };
>  
> +struct iio_trigger; /* forward declaration */
> +
>  /**
>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>   * @owner:		used to monitor usage count of the trigger.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/