linux-kernel - Re: [PATCH] Staging : lustre: Struct file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Aug 2015 13:26:16 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Shraddha Barke <shraddha.6596@...il.com>
cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Frank Zago <fzago@...y.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging : lustre: Struct file_operations should be
 const



On Sun, 2 Aug 2015, Shraddha Barke wrote:

> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: struct file_operations should normally be const

This is not the good way to write the message.  The information it conveys 
is "checkpatch generated this warning, so I have made some change 
(unspecified) that make checkpatch not complain".

A better approach would be to say:

Declare the file_operations structure ll_file_operations as const, as done 
elsewhere in the kernel, as there are no modifications to its fields.

Problem found using checkpatch.

This way the reader knows what was done, and what issues were taken into 
account when making the change.  At the same time, you still credit 
checkpatch for helping you find the problem

julia

> 
> Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
> ---
>  drivers/staging/lustre/lustre/llite/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index dcd0c6d..369a722 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3116,7 +3116,7 @@ int ll_inode_permission(struct inode *inode, int mask)
>  }
>  
>  /* -o localflock - only provides locally consistent flock locks */
> -struct file_operations ll_file_operations = {
> +const struct file_operations ll_file_operations = {
>  	.read_iter = ll_file_read_iter,
>  	.write_iter = ll_file_write_iter,
>  	.unlocked_ioctl = ll_file_ioctl,
> -- 
> 2.1.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/