linux-kernel - Re: [PATCH 1/1] tty/serial: jsm: Added spaces in if sentences and around binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Aug 2015 16:33:32 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jose Manuel Abuin Mosquera <abuinjm@...il.com>
Cc:	cascardo@...ux.vnet.ibm.com, jslaby@...e.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] tty/serial: jsm: Added spaces in if sentences and
 around binary operators

On Thu, Jul 30, 2015 at 09:36:05AM +0200, Jose Manuel Abuin Mosquera wrote:
> From: "Jose M. Abuin" <abuinjm@...il.com>
> 
> Added a blank line between variable declaration and code.
> Changed printk(KERN_INFO by pr_info( in some lines.
> Fixed space separations in if - else sentences.
> Added spaces between binary operators and variables.
> Variable assignation outside if in line 766.

A patch should only do one thing.  You are doing multiple things here in
this patch so please break it out into multiple patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/