lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 04 Aug 2015 14:00:09 +0200
From:	Matias <mb@...htnvm.io>
To:	Pavel Machek <pavel@....cz>
CC:	hch@...radead.org, axboe@...com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
	Stephen.Bates@...s.com, keith.busch@...el.com,
	Javier González 
	<jg@...htnvm.io>
Subject: Re: [PATCH v6 5/5] nvme: LightNVM support

On 08/02/2015 09:57 AM, Pavel Machek wrote:
> Hi!
>
>> +struct nvme_nvm_hb_rw {
>> +	__u8			opcode;
>> +	__u8			flags;
>> +	__u16			command_id;
>> +	__le32			nsid;
>> +	__u64			rsvd2;
>> +	__le64			metadata;
>> +	__le64			prp1;
>> +	__le64			prp2;
>> +	__le64			slba;
>> +	__le16			length;
>> +	__le16			control;
>> +	__le32			dsmgmt;
>> +	__le64			phys_addr;
>> +};
>
> You are not exporting this to userland, so you can get rid of "__"s.
>
>      	    	      	      		       	       	      Pavel
> 							
>

Thanks. I will get them removed. It was a leftover for when it was in 
the nvme uapi header.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ