linux-kernel - Re: [PATCH] regulator: da9063: Add set_voltage_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Aug 2015 19:33:22 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	kernel@...gutronix.de, support.opensource@...semi.com
Subject: Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function

On Thu, Aug 06, 2015 at 06:38:24PM +0200, Philipp Zabel wrote:
> This allows to set the regulator-ramp-delay in the device tree.

> @@ -433,6 +433,7 @@ static struct regulator_ops da9063_buck_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.get_voltage_sel	= regulator_get_voltage_sel_regmap,
>  	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
> +	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
>  	.list_voltage		= regulator_list_voltage_linear,
>  	.set_current_limit	= da9063_set_current_limit,
>  	.get_current_limit	= da9063_get_current_limit,

This doesn't seem right - we shouldn't need to manually add this to
every device to get the generic property to work.  Instead we ought to
just do this by default if there's nothing defined in the driver and we
see that a value was provided by DT.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)