[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 8 Aug 2015 19:40:26 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
eranian@...gle.com, namhyung@...nel.org,
Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/7] perf, tools, stat: Abstract stat metrics printing
On Fri, Aug 07, 2015 at 05:51:54PM -0700, Andi Kleen wrote:
SNIP
> +
> static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> {
> FILE *output = stat_config.output;
> @@ -516,7 +557,6 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> FILE *output = stat_config.output;
> double sc = evsel->scale;
> const char *fmt;
> - int cpu = cpu_map__id_to_cpu(id);
>
> if (csv_output) {
> fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
> @@ -529,9 +569,6 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
>
> aggr_printout(evsel, id, nr);
>
> - if (stat_config.aggr_mode == AGGR_GLOBAL)
> - cpu = 0;
> -
> fprintf(output, fmt, avg, csv_sep);
>
> if (evsel->unit)
> @@ -543,12 +580,30 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
>
> if (evsel->cgrp)
> fprintf(output, "%s%s", csv_sep, evsel->cgrp->name);
> +}
>
> - if (csv_output || stat_config.interval)
> - return;
> +static void printout(int id, int nr, struct perf_evsel *counter, double uval)
> +{
> + struct outstate os = { .fh = output };
hum..
CC builtin-stat.o
builtin-stat.c: In function ‘printout’:
builtin-stat.c:587:31: error: ‘output’ undeclared (first use in this function)
struct outstate os = { .fh = output };
^
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists