linux-kernel - Re: [PATCH] perf, tools, report: Add support for srcfile sort key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 8 Aug 2015 04:27:35 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
	namhyung@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools, report: Add support for srcfile sort key

On Fri, Aug 07, 2015 at 09:02:15PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 07, 2015 at 08:51:45PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Aug 07, 2015 at 03:54:24PM -0700, Andi Kleen escreveu:
> > > From: Andi Kleen <ak@...ux.intel.com>
> > > 
> > > In some cases it's useful to characterize samples by file. This is useful
> > > to get a higher level categorization, for example to map cost to
> > > subsystems.
> > > 
> > > Add a srcfile sort key to perf report. It builds on top of the existing
> > > srcline support.
> > 
> > Applied
> 
> Humm, holding this up a bit, further testing showed some oddities,
> fedora21, the width of the column is being limited to the lenght of the
> header

Yes I've seen that, I just use -w normally. It also happens with --sort
srcline. The column sizing code could probably be somewhat smarter and
always allow the last column to become as wide as needed. But that's
something that should be done separately; I don't think it belongs
into this patch.

> and there are some DWARF errors, have you noticed those?

No I didn't. Some generic issue, likely happening with srcline and
perhaps even objdump -S too. Find out with strace what file it is.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/