linux-kernel - Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2015 12:35:50 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>, stsp@...rs.sourceforge.net,
	Andrew Lunn <andrew@...n.ch>,
	Peter Meerwald <p.meerwald@...-electronic.com>
Subject: Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue

Hi Ricardo,

Thanks for the review.

On 08/11/2015 12:00 PM, Ricardo Ribalda Delgado wrote:
> Hello Jacek
>
> Sorry for the late reply.
>
> On Tue, Aug 11, 2015 at 11:37 AM, Jacek Anaszewski
> <j.anaszewski@...sung.com> wrote:
>
>
>>   struct pca963x_led {
>>          struct pca963x *chip;
>> -       struct work_struct work;
>>          enum led_brightness brightness;
>>          struct led_classdev led_cdev;
>>          int led_num; /* 0 .. 15 potentially */
>> -       enum pca963x_cmd cmd;
>>          char name[32];
>>          u8 gdc;
>>          u8 gfrq;
>>   };
>
> Maybe you want to remove also brightness, gdc and gfrq and pass them
> as arguments to the functions.
>
>> -static void pca963x_blink_work(struct pca963x_led *pca963x)
>> +static void pca963x_blink(struct pca963x_led *pca963x)
>
> something like: blink(pca963x, gdc, gfrq)

OK, I'll check it.

>
> Big disclaimer: i havent tested it on real hardware. Maybe next week I
> can get hold of a board with a pca chip.
>
>
> BTW: great thing that the work queue is implemented in the core :)

So far it is only in this patch set, but hopefully we will manage
to merge it soon.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/