linux-kernel - [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2015 10:04:04 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Adrian Huang <ahuang12@...ovo.com>, Egbert Eich <eich@...e.de>,
	Diego Ercolani <diego.ercolani@...il.com>,
	Borislav Petkov <bp@...e.de>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	<rtc-linux@...glegroups.com>
Subject: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix

We currently see this warning:

drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err'

introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos:
Cancel alarm timer if alarm time is equal to now+1 seconds").

Presumably some WIP version of the commit was doing error checking
but then the variable was not removed prior to submission, and the
pending commits weren't on kernel.org for kbuild bot to spot the new
warning created.

Cc: Adrian Huang <ahuang12@...ovo.com>
Cc: Egbert Eich <eich@...e.de>
Cc: Diego Ercolani <diego.ercolani@...il.com>
Cc: Borislav Petkov <bp@...e.de>
Cc: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc: Alessandro Zummo <a.zummo@...ertech.it>
Cc: rtc-linux@...glegroups.com
Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
---

[Note: patch is against linux-next, so if the rtc tree is rebased,
 then the above commit ID reference will be stale.  Feel free to
 adjust the commit log appropriately, if need be, or even squash
 this into the original offending patch, if rebasing back that far.
 Also ensuring your tree is on kernel.org will allow kbuild bot
 to spot these on your behalf via the zero day builds.]

 drivers/rtc/rtc-cmos.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 916bd1f555e5..c2e90c62a59c 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -848,7 +848,6 @@ static int cmos_aie_poweroff(struct device *dev)
 	 */
 	if (cmos->alarm_expires == t_now + 1) {
 		struct rtc_wkalrm alarm;
-		int err;

 		/* Cancel the AIE timer by configuring the past time. */
 		rtc_time64_to_tm(t_now - 1, &alarm.time);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/