linux-kernel - Re: [PATCH v2] asus-laptop: Add key found on Asus F3M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Aug 2015 09:06:08 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Łukasz Stelmach <stlman@...zta.fm>,
	acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] asus-laptop: Add key found on Asus F3M

On Wed, Aug 5, 2015 at 10:29 PM, Darren Hart <dvhart@...radead.org> wrote:
> On Wed, Jul 29, 2015 at 09:31:23PM +0200, Łukasz Stelmach wrote:
>> Asus F3M has two keys labeled with an icon of a touchpad. The first,
>> reported as 0x6B is next to the power key and the second, reported as
>> 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was
>> getting "Unknown key 6a pressed" message before applying this patch.
>>
>> Asus F3M does not support WMI so the commit does not update key mappings
>> in the asus-nb-wmi.c file.
>>
>> I have not tested this mapping on any other Asus laptop.
>>
>> Signed-off-by: Łukasz Stelmach <stlman@...zta.fm>
>
> Thanks Łukasz.
>
> Corentin, any concerns?

Acked-by: Corentin Chary <corentin.chary@...il.com>

Sorry for the delay, I won't really have a stable internet connection
until October.

>
>> ---
>>  drivers/platform/x86/asus-laptop.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
>> index 58d29c4..f2b5d0a 100644
>> --- a/drivers/platform/x86/asus-laptop.c
>> +++ b/drivers/platform/x86/asus-laptop.c
>> @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = {
>>       {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */
>>       {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */
>>       {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */
>> +     {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */
>>       {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */
>>       {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */
>>       {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */
>> --
>> 2.1.4
>>
>>
>
> --
> Darren Hart
> Intel Open Source Technology Center



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/