linux-kernel - Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 16:57:32 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Baoquan He <bhe@...hat.com>
Cc:	Minfei Huang <mnfhuang@...il.com>, akpm@...ux-foundation.org,
	kexec@...ts.infradead.org, ebiederm@...ssion.com,
	vgoyal@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional
 judgement to simplify the code logic

On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote:
> On 08/13/15 at 09:55am, Simon Horman wrote:
> > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> > > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > > we can simplify the code logic to do the image->control_page assignment
> > > directly in the loop, and remove the unnecessary conditional judgement.
> > > 
> > > Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> > > Acked-by: Dave Young <dyoung@...hat.com>
> > > Acked-by: Vivek Goyal <vgoyal@...hat.com>
> > 
> > Andrew, could you consider picking this up.
> > It seems to have been sufficiently reviewed, acked, etc...
> 
> I saw this has been in linux-next tree.

Excellent, sorry for the noise.

> commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69
> Author: Minfei Huang <mnfhuang@...il.com>
> Date:   Thu Jul 30 09:56:18 2015 +1000
> 
>     kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
> 
> Thanks
> Baoquan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/