linux-kernel - Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 09:43:46 -0600
From:	Al Stone <al.stone@...aro.org>
To:	Timur Tabi <timur@...eaurora.org>
Cc:	linux-acpi@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linaro-kernel@...ts.linaro.org, linux-ia64@...r.kernel.org,
	patches@...aro.org, linux-pm@...r.kernel.org,
	linaro-acpi@...ts.linaro.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	lkml <linux-kernel@...r.kernel.org>, Len Brown <lenb@...nel.org>
Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry()
 function to eventually replace the macro

On 08/12/2015 04:35 PM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@...aro.org> wrote:
>> +       while (ms->num_types != 0) {
>> +               if (ms->major_version == major &&
>> +                   ms->minor_version == minor &&
>> +                   ms->madt_version == madt->header.revision)
>> +                       break;
>> +               ms++;
>> +       }
>> +       if (!ms) {
> 
> Shouldn't this be
> 
>   if (!ms->num_types) {
> 
> instead?
> 

Argh.  Yes, it should.  It will always be false, otherwise.
Will fix for next version.  Thanks for catching that.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@...aro.org
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/