linux-kernel - Patch "md/bitmap: return an error when bitmap superblock is corrupt." has been added to the 3.14-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 10:25:28 -0700
From:	<gregkh@...uxfoundation.org>
To:	neilb@...e.com, gqjiang@...e.com, linux-kernel@...r.kernel.org,
	linux-raid@...r.kernel.org, rgoldwyn@...e.com
Cc:	<stable@...r.kernel.org>, <stable-commits@...r.kernel.org>
Subject: Patch "md/bitmap: return an error when bitmap superblock is corrupt." has been added to the 3.14-stable tree


This is a note to let you know that I've just added the patch titled

    md/bitmap: return an error when bitmap superblock is corrupt.

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     md-bitmap-return-an-error-when-bitmap-superblock-is-corrupt.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@...r.kernel.org> know about it.


>From neilb@...e.com  Fri Aug 14 10:23:56 2015
From: NeilBrown <neilb@...e.com>
Date: Fri, 14 Aug 2015 17:04:21 +1000
Subject: md/bitmap: return an error when bitmap superblock is corrupt.
To: stable@...r.kernel.org, linux-raid <linux-raid@...r.kernel.org>
Cc: GuoQing Jiang <gqjiang@...e.com>, Goldwyn Rodrigues <rgoldwyn@...e.com>, lkml <linux-kernel@...r.kernel.org>
Message-ID: <20150814170421.60d40eb0@...le>

From: NeilBrown <neilb@...e.com>

commit b97e92574c0bf335db1cd2ec491d8ff5cd5d0b49 upstream
    Use separate bitmaps for each nodes in the cluster

bitmap_read_sb() validates the bitmap superblock that it reads in.
If it finds an inconsistency like a bad magic number or out-of-range
version number, it prints an error and returns, but it incorrectly
returns zero, so the array is still assembled with the (invalid) bitmap.

This means it could try to use a bitmap with a new version number which
it therefore does not understand.

This bug was introduced in 3.5 and fix as part of a larger patch in 4.1.
So the patch is suitable for any -stable kernel in that range.

Fixes: 27581e5ae01f ("md/bitmap: centralise allocation of bitmap file pages.")
Signed-off-by: NeilBrown <neilb@...e.com>
Reported-by: GuoQing Jiang <gqjiang@...e.com>

---
 drivers/md/bitmap.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -564,6 +564,8 @@ static int bitmap_read_sb(struct bitmap
 	if (err)
 		return err;
 
+	err = -EINVAL;
+
 	sb = kmap_atomic(sb_page);
 
 	chunksize = le32_to_cpu(sb->chunksize);


Patches currently in stable-queue which might be from neilb@...e.com are

queue-3.14/md-raid1-extend-spinlock-to-protect-raid1_end_read_request-against-inconsistencies.patch
queue-3.14/md-bitmap-return-an-error-when-bitmap-superblock-is-corrupt.patch
queue-3.14/md-use-kzalloc-when-bitmap-is-disabled.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/