linux-kernel - Re: [PATCH V3 5/6] slimbus: Add support for 'clock-pause' feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 19:39:18 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sagar Dharia <sdharia@...eaurora.org>
Cc:	gregkh@...uxfoundation.org, bp@...e.de, poeschel@...onage.de,
	treding@...dia.com, gong.chen@...ux.intel.com,
	andreas.noever@...il.com, alan@...ux.intel.com,
	mathieu.poirier@...aro.org, daniel@...ll.ch, oded.gabbay@....com,
	jkosina@...e.cz, sharon.dvir1@...l.huji.ac.il, joe@...ches.com,
	davem@...emloft.net, james.hogan@...tec.com,
	michael.opdenacker@...e-electrons.com, daniel.thompson@...aro.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kheitke@...ience.com, mlocke@...eaurora.org, agross@...eaurora.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V3 5/6] slimbus: Add support for 'clock-pause' feature

On Mon, Aug 03, 2015 at 12:59:49AM -0600, Sagar Dharia wrote:

> @@ -459,6 +459,8 @@ int slim_register_controller(struct slim_controller *ctrl)
>  	mutex_init(&ctrl->m_ctrl);
>  	spin_lock_init(&ctrl->tx.lock);
>  	spin_lock_init(&ctrl->rx.lock);
> +	mutex_init(&ctrl->sched.m_reconf);
> +	init_completion(&ctrl->sched.pause_comp);

Should there not be more interaction with the rest of the framework on
clock pauses - the bus will need to be started to do transfers for
example?

> +#include <linux/slimbus.h>
> +/**

Missing blank line.

> + * slim_ctrl_clk_pause: Called by slimbus controller to enter/exit 'clock pause'

Is the controller the best place to initiate bus pausing?  It's
surprising to me that it would be, the bus being idle isn't something
that needs controller specific knowledge so I'd expect the framework to
have standard support for this.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)